Drop Python 3.6 support #1512
Merged
Drop Python 3.6 support #1512
+13
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roshii
suggested changes
Jul 27, 2023
kristapsk
force-pushed
the
drop-python-3.6
branch
from
032e698
to
a299070
Compare
Code I myself touched recently. 🤦♂️ |
roshii
approved these changes
Jul 27, 2023
|
So it seems a little pointless trying to test anything here, since this only reduces what can be made to work, there is no new functionality (checking that the programs still install/run is trivial). But perhaps add a note (I don't think we had it before, outside of release notes) to README.md and INSTALL.md? |
Yes, it's good idea to specify basic requirements in docs, will do. |
|
Thanks for adding the notes. ACK 5a345c6 |
kristapsk
force-pushed
the
drop-python-3.6
branch
from
5a345c6
to
9f4da21
Compare
|
@kristapsk |
kristapsk
added a commit
that referenced
this pull request
Aug 6, 2023
…tcoin` 90fe9b2 Fix pyaes dependency, should be in jmbase, not jmbitcoin (Kristaps Kaupe) Pull request description: Mistake was made while merging #1512. ACKs for top commit: AdamISZ: ACK 90fe9b2 Tree-SHA512: 30bc461bf7055bf8af81fc4165492c7f06bb6b923b7e92878dccbfb6d8e14d15950a7d3c5b9b5d681fbd8701cc3a028ad1f10bbc3b56346e387092c3eb88178b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's EOL since end of 2021 and 3.7+ will be minimum for #1484.